Bump Monaco to 0.18.1

[PHameete]

Closes #176

Updated Monaco to 0.18.1.

[gitpod-io-legacy-app]

Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE.

[PHameete]

@akosyakov I've added the changes for the two TODOs as well.

[PHameete]

@akosyakov I'll be on vacation for a week. Could you take a look at this in the meantime? When I'm back it would be cool if we can test the new dev release or fix any potential issues that remain. Cheers!

[akosyakov]

@PHameete Could you make sure that you have this check on: https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests? It will allow us to fix any issues with additional commits to this PR and then merge it. Thank you!

[PHameete]

@akosyakov it's done. Cheers!

[rcjsuen]

Do we need to update examples/brower/package.json?

monaco-languageclient/examples/browser/package.json

Lines 4 to 6 in bab5efa

	"version": "0.10.2",
	"dependencies": {
	"monaco-languageclient": "^0.10.2",

[PHameete]

After the language client version is incremented , yes.

[akosyakov]

@rcjsuen it happens automatically during release:

monaco-languageclient/package.json

Line 23 in bab5efa

"publish:latest": "lerna publish minor",

[akosyakov]

I won't be able to have a look in October. If someone can review and merge, go ahead. After merging on master it will be available under next tag. I also published it under dev tag for downstream testing.

[PHameete]

I've tested the dev release for our DSL editor. For us all existing behavior are still working correctly, and quickfix is now working as well.
We are not using the SignatureHelpContext or retrigger characters so I was not able to test those two additions.

[mhintzke]

+1

@PHameete Oh wow thank you for doing this!

I just spent the last 2 hours diving into all the code trying to figure out why the runtime was blowing up and this PR is 100% the fix to all of the problems I'm having. I would love to get this bumped and reviewed ASAP as well, otherwise I'm going to have to cherry-pick your build into my app.

[PHameete]

@mhintzke13 this version is already published on npm as version 0.10.3-dev.3
Its just not reviewed/battle tested but you can try it out. I'm using this version myself and have had no issues so far. I don't use the full feature set of monaco though.

[mhintzke]

@PHameete oh ok awesome, that will make this much easier to use then. Our application is still in its infancy, so I presume everything will work just fine once these runtime exceptions are fixed. I will give it a shot and let you know how things turn out. Thanks again!

[PHameete]

@akosyakov can you review this if you have some time for it?

[CGNonofr]

We use it in production for several weeks and everything works fine so far!

[gins3000]

Any updates with this, or help needed?

[PHameete]

Waiting for a maintainer to verify and publish. I guess TypeFox has different priorities currently. Is it possible that more maintainers are added for this project?

[gins3000]

@mhintzke13 this version is already published on npm as version 0.10.3-dev.3
Its just not reviewed/battle tested but you can try it out. I'm using this version myself and have had no issues so far. I don't use the full feature set of monaco though.

Thanks! I have upgraded to this version myself now, and it looks to be working nicely (just to add another +1 voice to those who are using it already).

[apupier]

@PHameete the branch is marked as "out-of-date with the base branch"

[johnwiseheart]

Looks reasonable to me, especially since its been on the dev track for a while. ANy issues can be fixed up as future PRs

[johnwiseheart]

According to @akosyakov this should end up under the next tag now?

[akosyakov]

According to @akosyakov this should end up under the next tag now?

yes

I'v also just published it under latest as 0.11.0

[PHameete]

Thank you @akosyakov