Resolve code actions #290
Merged
Resolve code actions #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGNonofr
requested review from
asual,
azatsarynnyy,
BroKun,
gatesn,
johnwiseheart,
mofux,
rcjsuen and
RomanNikitenko
as code owners
|
@mofux still counting on you ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In last version of the lsp specification, the
editfield in a CodeAction is not mandatory anymore.In such case, the client is supposed to call the server to resolve it when it needs to.
Unfortunately, the monaco api doesn't provide the way to do it properly.
As soon as microsoft/monaco-editor#2663 is resolved, it will need to be properly implemented, this is a temporary "hack"