Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropped tags in Diagnostic -> IMarkerData #297

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

rw-access
Copy link
Contributor

@rw-access rw-access commented Oct 29, 2021

When converting diagnostics from the language client DIagnostic from into IMarkerData, the tag field was dropped.

This keeps that field present in the diagnostic.

Here's confirmation of this locally with the Unnecessary tag on all false values, and no diagnostics on true:
Screen Shot 2021-10-29 at 4 22 43 PM

@CGNonofr
Copy link
Collaborator

CGNonofr commented Nov 2, 2021

Thank you 👍

Can you just squash your 2 commits please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants