Fix dropped tags in Diagnostic -> IMarkerData #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting diagnostics from the language client DIagnostic from into IMarkerData, the
tag
field was dropped.This keeps that field present in the diagnostic.
Here's confirmation of this locally with the
![Screen Shot 2021-10-29 at 4 22 43 PM](https://user-images.githubusercontent.com/31489089/139507658-982383da-9a7e-47d9-a0d6-bb0caf4f5b12.png)
Unnecessary
tag on allfalse
values, and no diagnostics ontrue
: