Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to monaco 0.33 & vscode 1.65 #329

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Update to monaco 0.33 & vscode 1.65 #329

merged 4 commits into from
Mar 15, 2022

Conversation

CGNonofr
Copy link
Collaborator

No description provided.

@CGNonofr CGNonofr requested a review from kaisalmen March 14, 2022 11:19
@CGNonofr CGNonofr changed the title Update to monaco 0.33 vscode 1.65 Update to monaco 0.33 & vscode 1.65 Mar 14, 2022
@CGNonofr
Copy link
Collaborator Author

@mofux if you're still around here, I'd like you review as well

Copy link
Collaborator

@mofux mofux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you. We could release 0.18.0 this week and afterwards work on enhancements.

@CGNonofr
Copy link
Collaborator Author

it looks like there is a CI/travis issue, can you merge it and release the next version @kaisalmen ?

@kaisalmen
Copy link
Collaborator

Yes, I will merge and produce a release. The CI seems to not working at all. Something for the needs fixing list.

@kaisalmen kaisalmen merged commit 2bea308 into master Mar 15, 2022
@kaisalmen
Copy link
Collaborator

kaisalmen commented Mar 15, 2022

@CGNonofr On thing I overlooked. Shouldn't @types/vscode and "engines": { "vscode": "^1.50.0" } (client) be aligned to 1.65.0. I could update and commit this on the master together with CHANGELOG.

@CGNonofr
Copy link
Collaborator Author

I admit I have no idea what that engine if for

@kaisalmen
Copy link
Collaborator

If I understand it correctly here it specifies the minimum required vscode engine if you build a language client for vscode. Then this could be removed here. Do you agree?

@CGNonofr
Copy link
Collaborator Author

I think you're right!

@kaisalmen
Copy link
Collaborator

0.18.0 is released

@CGNonofr
Copy link
Collaborator Author

you rock

@CGNonofr
Copy link
Collaborator Author

btw, what about taking back the @codingame/monaco-jsonrpc library as well?

@kaisalmen
Copy link
Collaborator

Yes, good idea. that's already on the list for #315. I was even thinking about putting it as a sub-package in here?

@CGNonofr
Copy link
Collaborator Author

By sub-package, do you still mean it will be a separate package on npmjs?

@kaisalmen
Copy link
Collaborator

kaisalmen commented Mar 15, 2022

Yes, it stays separate package on npmjs, but a "sub-"package of potential, future npm workspace here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants