-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to monaco 0.33 & vscode 1.65 #329
Conversation
@mofux if you're still around here, I'd like you review as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thank you. We could release 0.18.0 this week and afterwards work on enhancements.
it looks like there is a CI/travis issue, can you merge it and release the next version @kaisalmen ? |
Yes, I will merge and produce a release. The CI seems to not working at all. Something for the needs fixing list. |
@CGNonofr On thing I overlooked. Shouldn't |
I admit I have no idea what that |
If I understand it correctly here it specifies the minimum required vscode engine if you build a language client for vscode. Then this could be removed here. Do you agree? |
I think you're right! |
0.18.0 is released |
you rock |
btw, what about taking back the |
Yes, good idea. that's already on the list for #315. I was even thinking about putting it as a sub-package in here? |
By sub-package, do you still mean it will be a separate package on npmjs? |
Yes, it stays separate package on npmjs, but a "sub-"package of potential, future npm workspace here. |
No description provided.