Fix vscode api enum #333
Fix vscode api enum #333
Conversation
CGNonofr
requested review from
gatesn,
mofux,
BroKun,
rcjsuen,
asual,
johnwiseheart,
RomanNikitenko and
azatsarynnyy
as code owners
|
@kaisalmen I think this fix is pretty urgent |
| @@ -119,6 +119,14 @@ export function createVSCodeApi(servicesProvider: Services.Provider): typeof vsc | |||
| } | |||
| } | |||
|
|
|||
| enum TextDocumentChangeReason { | |||
There was a problem hiding this comment.
Question for my understanding: We have to redefine the enum because otherwise vscode api is exposed in the listener?
There was a problem hiding this comment.
The error was at line reason: isUndoing ? vscode.TextDocumentChangeReason.Undo : isRedoing ? vscode.TextDocumentChangeReason.Redo : undefined
vscode.TextDocumentChangeReason wasn't defined so it was crashing
I hope I understood your question
There was a problem hiding this comment.
Yes, you understood me. Thanks. 👍🙂 Just by looking at the PR without having deep knowledge of the project yet doesn't make the problem directly clear. That's why import type (did not know it and looked it up) is very helpful here as it immediately makes the issue obvious.
There was a problem hiding this comment.
👍 The same way we need to re-implement all vscode.* interfaces, enums in typescript are transpiled into objects, and we need those at runtime
|
I will merge and release |
you rock! |
|
Done ✅ |
Great! thank you and my apologies for the bug! btw, any news for the other MR? |
fix for #332