Add some typing on the code/proto converters #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGNonofr
requested review from
gatesn,
mofux,
BroKun,
rcjsuen,
asual,
johnwiseheart,
RomanNikitenko and
azatsarynnyy
as code owners
Closed
|
@kaisalmen I think we'll quickly need a 1.0.1 :) |
|
Yes, seems so. I didn't really have the time to look or try these changes, but the overall approach is good. It is more verbose, but it is very clear what happens 👍 |
kaisalmen
approved these changes
May 23, 2022
I've only tested it on the example and it didn't seem to break anything (and the original big is fixed) Will you be able to publish it? |
|
I want to downgrade and fix vite to 2.9.6. I have done this in two other projects, so once you merge I will push this on the main branch and then can publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to fix #357