-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported features #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how the "optional" feature should work.
this.registerFeature(new DiagnosticFeature(this)); | ||
} | ||
|
||
public registerTextDocumentSaveFeatures() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is responsible for calling three methods (registerTextDocumentSaveFeatures
, registerConfigurationFeatures
, registerProgressFeatures
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user who is using the MonacoLanguageClient, aka,
const languageClient = new MonacoLanguageClient(...)
languageClient.registerTextDocumentSaveFeatures()
Since these feature are builtin in vscode but NOT builtin in monaco (they require some additional code), I don't thing they belong in the registerBuiltinFeatures
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some features are not supported at all:
Some require some code and are not
builtin
: