-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce global engines entries for node and npm #370
Conversation
Good idea 👍 btw, what about adding the volta config as well? |
I didn't know that one. I had to look it up. It makes sense. Do you use it and do you recommend it? I am working with Windows/Linux (WSL2) hybrid machines, so I am always interested in things that work in both worlds. |
Yes we do use volta everywhere at CodinGame for some months |
"node": ">=16.0.0", | ||
"npm": ">=7.10.0" | ||
}, | ||
"volta": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinned the latest version of node and npm. Is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shouldn't we generally stick to node LTS? npm
7.10.0
is the npm version bundled with node16.0.0
that's why I choose that version number.