Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align all tsconfigs and vscode-ws-jsonrpc provides esm/cjs #390

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Align all tsconfigs and vscode-ws-jsonrpc provides esm/cjs #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a69dba
Align all tsconfigs and compile vscode-ws-jsonrpc to esm and cjs
kaisalmen Jun 22, 2022
31bd60b
Remove AMD and CJS build, but keep monaco-converter(/cjs)
kaisalmen Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,9 @@ module.exports = {
'dot-notation': 'off',
'@typescript-eslint/dot-notation': ['error']
},
ignorePatterns: ['.eslintrc.js', './packages/examples/browser-lsp/src/serverWorker.ts']
ignorePatterns: [
'.eslintrc.js',
'vite.config.ts',
'packages/examples/browser-lsp/src/serverWorker.ts'
]
};
33 changes: 14 additions & 19 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,22 @@
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch Sample Server",
"program": "${workspaceRoot}/packages/examples/node/lib/server.js",
"sourceMaps": true,
"outFiles": [
"${workspaceRoot}/packages/examples/node/lib/**/*.js"
]
"name": "Launch Sample Server",
"type": "node",
"request": "launch",
"args": ["${workspaceRoot}/packages/examples/node/src/server.ts"],
"runtimeArgs": ["--nolazy", "-r", "ts-node/register"],
"cwd": "${workspaceRoot}/packages/examples/node",
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Launch Sample Server (external)",
"program": "${workspaceRoot}/packages/examples/node/lib/server.js",
"args": [
"--external"
],
"sourceMaps": true,
"outFiles": [
"${workspaceRoot}/packages/examples/node/lib/**/*.js"
]
"name": "Launch Sample Server (external)",
"type": "node",
"request": "launch",
"args": ["${workspaceRoot}/packages/examples/node/dist/server.js", "--external"],
"runtimeArgs": ["--nolazy", "-r", "ts-node/register"],
"cwd": "${workspaceRoot}/packages/examples/node",
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "pwa-chrome",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Or you use a fresh dev environment in [Gitpod](https://www.gitpod.io) which is a

### Scripts Overview

The main [package.json](./package.json) contains script entries applicable to the whole workspace like `clean` amd `compile`, but it also has entries for launching script from the packages (lib and examples).
The main [package.json](./package.json) contains script entries applicable to the whole workspace like `clean` and `compile`, but it also has entries for launching script from the packages (lib and examples).

For example if you want to rebuild the library you can do it in different ways. From CLI run one of:
```bash
Expand Down
122 changes: 77 additions & 45 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"npm": "8.11.0"
},
"scripts": {
"clean": "npm run clean --workspaces && npm run clean:amd --workspace packages/client && npm run webpack:clean --workspace packages/examples/client",
"clean": "npm run clean --workspaces && npm run webpack:clean --workspace packages/examples/client",
"compile": "npm run compile --workspaces",
"lint": "npm run lint --workspaces",
"dev": "vite --debug --force",
Expand Down
Loading