Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to monaco 0.34/vscode 1.69 #409

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Update to monaco 0.34/vscode 1.69 #409

merged 5 commits into from
Aug 16, 2022

Conversation

CGNonofr
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just released 0.34.0 of monaco-editor-workers and therefore pushed an update.

@kaisalmen
Copy link
Collaborator

Pushed the lock file.

@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Aug 15, 2022

Thanks! note that monaco-vscode-api@1.69 is ONLY compatible with monaco 0.34 therefore I think any monaco-languageclient update of monacy-editor should be a major release

@kaisalmen
Copy link
Collaborator

Yes, I was thinking the same thing. 3.0.0 shall it be! I will prepare the release.

Thank you for your work! I saw the service additions in monaco-vsocde-api.

@kaisalmen
Copy link
Collaborator

I have pushed another update with some changes to the README and CHANGELOG.
I tested it locally and it looks good.
If you think, we are good to go, please presse the merge button, then I will produce the release.

@CGNonofr CGNonofr merged commit 1fc5663 into main Aug 16, 2022
@CGNonofr CGNonofr deleted the update-monaco-0.34 branch August 16, 2022 10:26
@CGNonofr
Copy link
Collaborator Author

CGNonofr commented Aug 16, 2022

FYI, monaco-vscode-api was designed at first to only provide the programmatic VSCode api, but it evolved and now provides a way to use the declarative VSCode API (the things declared in the package.json of extensions)

I created a demo: CodinGame/monaco-vscode-api#39

@kaisalmen
Copy link
Collaborator

kaisalmen commented Aug 17, 2022

Forgot to write: Made the release yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants