-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not reexport code of imported libraries (e.g. vscode-languageclient) #459
Conversation
@CGNonofr This is not complete, but the new example may be of interest for you. Are the vscode default themes available via some npm package? Do you know this by any chance? |
Interesting! I'll have a look
Unfortunately no... they are only available as a vscode extension. I had to download the files by hands (So I guess the answer is yes are they are available in our monaco editor wrapper? :) |
Fixed some things and added a node script for fetching themes from code's GH repo. |
- Gather all examples in one folder
54f87fc
to
29e8206
Compare
@CGNonofr this is now ready for review. |
1512994
to
a96f797
Compare
@CGNonofr This PR exploded in size. Sorry. |
I have a deal then: will you have time to handle to update of monaco-vscode-api to monaco@0.36? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard to review indeed!
LGTM, I just don't know if integrating theme management in monaco-languageclient is relevant
I actually would like to understand how you do this whole transformation. My time next week is very limited, though.
I will make up my mind again. I will eventually move it to our monaco-editor-wrapper and have some stripped down version here. Do you think it makes sense to have a "theme helper" in |
pretty straighforward:
Maybe we can have something more generic which allows to load a vscode extension instead from a github url? |
Sounds like a good idea. Load and use (does |
Btw, I have published a couple of pre-release of 5.0.0 so far (current next is is |
That basically what we do in our @codingame/monaco-editor-wrapper. It probably make sense to make it more generic and put in inside monaco-vscode-api. |
This sounds like a good idea and could open a couple of more use cases 🎉 |
This PR ensure that monaco-languageclient and vscode-ws-jsonrpc no longer export imported packages.
Additional changes:
monaco-vscode-api
watch
available that watches code in all packages (except for angular and verify where this strategy cannot be applied).tsconfig.src.json
)I will release next packages to test the implementation and make this final once I think the PR is ready!