Update WorkspaceClientCapabilities to state that WorkspaceEdit's documentChanges is supported #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
workspace/applyEdit
was added in #21 but the capabilities of the client was not updated to includeworkspaceEdit: { documentChanges: true }
. This pull request adds this to the capabilities so that servers will know that this client supports this feature.In an earlier comment I had stated that our support for
documentChanges
was incomplete because no version checking was made. However, I was wrong because the versions were being checked byvscode-base-languageclient
.https://github.com/TypeFox/vscode-languageserver-node/blob/e0c1f194dabede0409f0d8f4e4e2eeccc65e1535/client/src/base.ts#L1502-L1512
Hence, the versions of the
documentChanges
have actually already been verified by the time they get to ourapplyEdit
function implementation.Sorry for the any confusion that I may have caused.