Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: localeLoader: allow manually select which locale to load #669

Merged
merged 2 commits into from
Jun 3, 2024
Merged

chore: localeLoader: allow manually select which locale to load #669

merged 2 commits into from
Jun 3, 2024

Conversation

undefined-moe
Copy link
Contributor

No description provided.

CGNonofr
CGNonofr reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea indeed!

kaisalmen
kaisalmen requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. No need to deprecate the wrong function name. Just drop that and then I will approve this. 🎉

packages/wrapper/src/vscode/localeLoader.ts Outdated Show resolved Hide resolved
kaisalmen
kaisalmen approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kaisalmen kaisalmen merged commit 952709d into TypeFox:main Jun 3, 2024
1 check passed
@undefined-moe undefined-moe deleted the patch-1 branch June 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGNonofr CGNonofr CGNonofr left review comments

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@undefined-moe @kaisalmen @CGNonofr