Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: Make codeResources and useDiffEditor optional in EditorAppConfig #670

Merged
merged 5 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ module.exports = {
],
parserOptions: {
ecmaVersion: 2022,
sourceType: 'module'
sourceType: 'module',
project: ['./tsconfig.json']
},
plugins: [
'@typescript-eslint',
Expand Down Expand Up @@ -80,6 +81,8 @@ module.exports = {
'@typescript-eslint/prefer-for-of': 'error', // prefer for-of loop over arrays
'@typescript-eslint/prefer-namespace-keyword': 'error', // prefer namespace over module in TypeScript
'@typescript-eslint/triple-slash-reference': 'error', // ban /// <reference />, prefer imports
'@typescript-eslint/type-annotation-spacing': 'error' // consistent space around colon ':'
'@typescript-eslint/type-annotation-spacing': 'error', // consistent space around colon ':'
'@typescript-eslint/strict-boolean-expressions': 'error', // Disallow certain types in boolean expressions
'@typescript-eslint/no-unnecessary-condition': 'error' // Disallow conditionals where the type is always truthy or always falsy
}
};
19 changes: 11 additions & 8 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Volta
uses: volta-cli/action@v4
CGNonofr marked this conversation as resolved.
Show resolved Hide resolved

- name: Use pnpm
uses: pnpm/action-setup@v3
with:
Expand All @@ -32,19 +32,22 @@ jobs:
run: |
npm ci

- name: Lint
- name: Build
shell: bash
run: |
npm run lint
npm run report:versions
npm run build

- name: Build
- name: Lint
shell: bash
run: |
npm run build
npm run report:versions
npm run lint

- name: Test
shell: bash
run: |
npm run report:versions
npm run test:run

- name: Build production
Expand Down
Loading