upgrade to monaco 0.12.0

[AlexTugarev]

Monaco 0.12.0 fixes some important bugs with previous version, cf. https://github.com/Microsoft/monaco-editor/issues?q=is%3Aissue+milestone%3A%22March+2018%22+is%3Aclosed.

API changes needed to be handled here are related to the monaco.editor.IMarkerData and monaco.MarkerSeverity interfaces.

[rcjsuen]

The code changes look reasonable. I noticed that the example prints out warnings during the build now. I don't know if this is an issue or not, the example seems to run fine anyway.

monaco-languageclient\example> npm install

> uglifyjs-webpack-plugin@0.4.6 postinstall monaco-languageclient\example\node_modules\webpack\node_modules\uglifyjs-webpack-plugin
> node lib/post_install.js


> @monaco-languageclient/example@0.0.1 prepare monaco-languageclient\example
> npm run clean && npm run build


> @monaco-languageclient/example@0.0.1 clean monaco-languageclient\example
> rimraf lib


> @monaco-languageclient/example@0.0.1 build monaco-languageclient\example
> npm run compile && webpack && npm run copy


> @monaco-languageclient/example@0.0.1 compile monaco-languageclient\example
> tsc

Hash: ea843e331c8700df302e
Version: webpack 3.11.0
Time: 31101ms
                      Asset       Size  Chunks                    Chunk Names
                0.bundle.js  384 bytes       0  [emitted]
             main.bundle.js    6.41 MB       1  [emitted]  [big]  main
    editor.worker.bundle.js     434 kB       2  [emitted]  [big]  editor.worker
            0.bundle.js.map  672 bytes       0  [emitted]
         main.bundle.js.map    6.82 MB       1  [emitted]         main
editor.worker.bundle.js.map     483 kB       2  [emitted]         editor.worker
  [52] (webpack)/buildin/global.js 509 bytes {1} {2} [built]
 [170] ../lib/disposable.js 1.38 kB {1} [built]
 [241] ../lib/commands.js 757 bytes {1} [built]
 [242] ../lib/console-window.js 1.98 kB {1} [built]
 [243] ../lib/languages.js 22.1 kB {1} [built]
 [244] ../lib/workspace.js 6.03 kB {1} [built]
 [245] ../lib/converter.js 25.8 kB {1} [built]
 [248] ../node_modules/monaco-editor-core/esm/vs/editor/common/services 160 bytes {0} [built]
 [249] ./lib/main.js 546 bytes {1} [built]
 [599] ./lib/client.js 3.35 kB {1} [built]
 [612] ../lib/index.js 926 bytes {1} [built]
 [619] ../lib/diagnostic-collection.js 3.29 kB {1} [built]
 [622] ../lib/services.js 853 bytes {1} [built]
 [626] (webpack)/buildin/module.js 517 bytes {1} [built]
    + 626 hidden modules

WARNING in ../node_modules/monaco-editor-core/esm/vs/editor/common/services/editorSimpleWorker.js
378:12-387:17 Critical dependency: the request of a dependency is an expression
 @ ../node_modules/monaco-editor-core/esm/vs/editor/common/services/editorSimpleWorker.js
 @ ../node_modules/monaco-editor-core/esm/vs/editor/editor.worker.js

> @monaco-languageclient/example@0.0.1 copy monaco-languageclient\example
> cp src/index.html lib/index.html

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.3 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 628 packages from 540 contributors in 141.458s

[akosyakov]

@AlexTugarev please take care of warnings in examples, otherwise it looks good.

BTW we published next version (0.5.0-1) as latest accidentally: https://www.npmjs.com/package/monaco-languageclient (versions tab)

Let's just make 0.5.0 latest release with this change. There is CHANGELOG file to be updated.

[AlexTugarev]

I see, 0.5.0-0 is also next.

[AlexTugarev]

On the dependency warnings, I'm not sure yet what changed and how to get rid of those. I have overlooked them in the beginning.

[gatesn]

Is there anything left I can help out with for this PR? We're running into some nasty 0.11.1 bugs sadly and don't particularly want to downgrade.

[AlexTugarev]

@gatesn, webpack warnings are still unresolved. I still couldn't get rid of them.

WARNING in ../node_modules/monaco-editor-core/esm/vs/editor/common/services/editorSimpleWorker.js
378:12-387:17 Critical dependency: the request of a dependency is an expression
 @ ../node_modules/monaco-editor-core/esm/vs/editor/common/services/editorSimpleWorker.js
 @ ../node_modules/monaco-editor-core/esm/vs/editor/editor.worker.js

Also same warnings in appear with monaco-editor-samples. Though I haven't seen any issues so far.

[akosyakov]

@AlexTugarev we can also open a follow-up and fix separately. If you are sure that it is not related to changes.

[AlexTugarev]

Sounds good. I'll update the branch shortly.