Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest LSP #89

Merged
merged 1 commit into from
Jul 31, 2018
Merged

upgrade to latest LSP #89

merged 1 commit into from
Jul 31, 2018

Conversation

akosyakov
Copy link
Contributor

vscode compatiblity layer is introduced to make use of vscode-languageclient directly instead of vscode-base-languageclient

@akosyakov akosyakov force-pushed the ak/vscode_comp branch 27 times, most recently from c7abcfb to 1a8247c Compare July 25, 2018 19:01
@akosyakov akosyakov changed the title WIP fix #24: get rid of vscode-base-languageclient WIP upgrade to latest LSP Jul 25, 2018
@akosyakov
Copy link
Contributor Author

Please review.

As the next step i am going to publish next version and test it with Theia.

@akosyakov akosyakov changed the title WIP upgrade to latest LSP upgrade to latest LSP Jul 25, 2018
Copy link
Collaborator

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't scrutinize the changes super thoroughly as there's quite a bit but I gave it a test run with my own language server and it seemed okay. Great work, Anton!

@akosyakov
Copy link
Contributor Author

@rcjsuen many thanks for trying it out

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akosyakov akosyakov mentioned this pull request Jul 26, 2018
akosyakov added a commit to TypeFox/vscode-languageserver-node that referenced this pull request Jul 26, 2018
I am working on new version of monaco-languageclient to catch it up with vscode-languageclient: TypeFox/monaco-languageclient#89
And for it i have to customize how a connection is created and which features are enabled by default.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to TypeFox/vscode-languageserver-node that referenced this pull request Jul 26, 2018
I am working on a new version of `monaco-languageclient` to catch it up with `vscode-languageclient`: TypeFox/monaco-languageclient#89
And for it, I have to customize how a connection is created and which features are enabled by default.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov force-pushed the ak/vscode_comp branch 8 times, most recently from a9064da to f691aec Compare July 30, 2018 09:32
@akosyakov
Copy link
Contributor Author

We've decided to keep vscode-base-languageclient as a vscode-languageclient transpiled to es5. As soon as microsoft/vscode-languageserver-node#382 is resolved, we can abandon vscode-base-languageclient completely.

@akosyakov akosyakov force-pushed the ak/vscode_comp branch 5 times, most recently from 9060e91 to f24cb59 Compare July 31, 2018 06:22
vscode compatibility layer is introduced in order to make use of vscode-languageclient directly instead of vscode-base-languageclient

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants