-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load custom transformers from tsconfig #552
Merged
Perryvw
merged 21 commits into
TypeScriptToLua:master
from
ark120202:load-custom-transformers
Jun 4, 2019
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cbf05eb
Load custom transformers from tsconfig
ark120202 1c68f73
Rename diagnostics imported namespace to diagnosticFactories
ark120202 1d4f2b0
Tests
ark120202 1d72e24
Add diagnostic when transformer could not be resolved
ark120202 de282fe
Rename "transform" to "name"
ark120202 f5209db
Validate name and when transformer options
ark120202 2f46cfc
Merge remote-tracking branch 'upstream/master' into load-custom-trans…
ark120202 8e2135a
Resolve ts-node from module location instead of base dir
ark120202 a353f22
Make .js files have higher priority during transformer resolution
ark120202 d6750e1
Rename variable
ark120202 cc144bd
Add ts-node as an optional peer dependency
ark120202 f04ac39
Merge remote-tracking branch 'upstream/master' into load-custom-trans…
ark120202 6da44e9
Add compatibility with ttypescript and support more transformer types
ark120202 a4c9c9a
Merge remote-tracking branch 'upstream/master' into load-custom-trans…
ark120202 a1a68e1
Remove old option tests
ark120202 1a14df9
Use original source file node in getEmitResolver
ark120202 c6edc48
Merge remote-tracking branch 'upstream/master' into load-custom-trans…
ark120202 ccc28e3
Move transformer loading code to a separate file
ark120202 2b1a6f0
Check for "transform" property existence instead of "name" non-existence
ark120202 5f10ec5
Merge remote-tracking branch 'upstream/master' into load-custom-trans…
ark120202 e0cf202
Remove ts-node optional peer dependency
ark120202 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid runtime deps if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's necessary in this case. Module resolution algorithm is complex and TS implementation isn't exposed and limited to types only. It's quite small, has only one sub-dependency and pretty much standard for customized module resolution, so IMO it's okay to add it. We'll need it for module support as well.