-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluded files trigger plugin a new incremental check. #558
Comments
Hi! Thanks for reporting this issue. Please create a reproduction repository :) |
I can confirm the same issue, as well as additional context. This plugin now reports on unreachable code when as before it didn't when option "allowUnreachableCode" is enabled. Also the plugin option "typescript.configOverwrite" does not actually work to exclude files. Either with "exclude" or "include". The only way that actually works with version 6 of the plugin to exclude is issue filtering, or downgrading back to version 5 of the plugin. |
Can confirm, "excludes" in tsconfig is getting ignored now. Code that was excluded and didn't throw any errors in 5.x will throw errors in 6.x with the same configs. |
As I said, please create a reproduction repository, so I can help. I have limited resources that I can spend working on this package, so I have to delegate the reproduction step to the community, sorry :) |
@piotr-oles I've already made a reproduction repository here: #580 I guess this issue could be closed as a duplicate? |
@grumd No, your issue is not related to this one :) |
@piotr-oles Hello again!) I've decided to give webpack 5 another try and everything is good except this particular issue with incremental checks :(
I will be very glad if you find some time and look into this issue. Let me know if I need to change something in the repository. Thanks! |
🎉 This issue has been resolved in version 6.2.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Current behavior
Excluded files trigger plugin a new incremental check.
Expected behavior
Excluded files must not trigger another incremental check.
Steps to reproduce the issue
I have the following webpack config parts:
ts-loader
fork-ts-checker-webpack-plugin
dist
folder✅ In version 5.2.1 I have the following results after I change a single character in a component in a watch mode:
❌ With the same configs in version 6.0.8 I have the following results after I change a single character in a component in a watch mode:
😢 For some reasons generated files from
dist
folder start to trigger another checks.Issue reproduction repository
Let me know if reproduction example is surely needed.
Environment
P.S. Let me know if this question should be asked somewhere else and not in github issues and sorry 😅
The text was updated successfully, but these errors were encountered: