Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid false positive of no-consecutive-blank-lines TSLint rule in Vue file #138

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

ktsn
Copy link
Contributor

@ktsn ktsn commented Aug 8, 2018

fix #130 (comment)

Now VueProgram adds // for each blank line to avoid that the tslint reports false positive no-consecutive-blank-lines warning.

Input:

<template>
  <p>Hello</p>
</template>

<script lang="ts">
import Vue from 'vue';
export default Vue.extend({});
</script>

Resolved TypeScript code:

//
//
//
//

import Vue from 'vue';
export default Vue.extend({});

@johnnyreilly
Copy link
Member

johnnyreilly commented Aug 8, 2018

Looks good - thanks! Will try and get this merged and shipped soon 👍

@johnnyreilly johnnyreilly merged commit 68ec1b6 into TypeStrong:master Aug 8, 2018
@ktsn ktsn deleted the vue-fix-blank-line branch August 8, 2018 10:57
@johnnyreilly
Copy link
Member

@ktsn
Copy link
Contributor Author

ktsn commented Aug 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants