Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoreLintWarnings shouldn't mark rule as error #243

Merged
merged 3 commits into from
Apr 11, 2019
Merged

ignoreLintWarnings shouldn't mark rule as error #243

merged 3 commits into from
Apr 11, 2019

Conversation

MQuy
Copy link
Contributor

@MQuy MQuy commented Apr 9, 2019

Nested condition to fix the case when warning is marked as error when enabling ignoreLintWarnings

@johnnyreilly
Copy link
Member

johnnyreilly commented Apr 9, 2019 •
edited
Loading

Thanks! Just requeued the test

@MQuy
Copy link
Contributor Author

MQuy commented Apr 11, 2019 •
edited
Loading

hi @johnnyreilly, seem that everything ok, can we merge this pr? 🤔

@johnnyreilly
Copy link
Member

Looks good!

Could you please contribute a unit test / update the changelog / version in package.json?

@MQuy
Copy link
Contributor Author

MQuy commented Apr 11, 2019 •
edited
Loading

I changed the version to 1.0.2-alpha.0 👍

@johnnyreilly
Copy link
Member

1.0.2 please

@johnnyreilly johnnyreilly merged commit 6bdf632 into TypeStrong:master Apr 11, 2019
@johnnyreilly
Copy link
Member

Thanks!

@johnnyreilly
Copy link
Member

Should ship shortly: https://github.com/Realytics/fork-ts-checker-webpack-plugin/releases/tag/v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MQuy @johnnyreilly