fix: use :line:col format in webpack errors

[robcrocombe]

Fixes #481

As discussed in #481, changes the format of TypeScript error file locations to use file:line:col. This means files can be opened from the terminal at the location the error occurred (e.g. cmd+click on Mac). Like this:

ERROR in /Users/.../customer.ts:86:16
TS2551: Property 'giveName' does not exist on type 'Customer'. Did you mean 'givenName'?
    84 |     }
    85 |     if (c.givenName) {
  > 86 |       return c.giveName;
       |                ^^^^^^^^
    87 |     }
    88 |     if (c.familyName) {
    89 |       return c.familyName;

The location end is still used in the code frame.

[robcrocombe]

The E2E tests are broken, I will take a look when I can.

[johnnyreilly]

Hey @robcrocombe

I just noticed you're a fellow Londoner. Hello fellow Londoner! Whereabouts do you work when you're in the office? I'm pretty central; though like everyone else I've been homebased since March.

[robcrocombe]

Hey @johnnyreilly yep, I'm based in Old Street :) Except for now I'm also working from home.

I've updated the tests to handle both formats, since I don't think the async: false option is being changed.

[johnnyreilly]

Hey @johnnyreilly yep, I'm based in Old Street :) Except for now I'm also working from home.

Haha nice! I'm near St Paul's Cathedral.... Daring to consider cycling into town sometime. Just to have my own personal 28 days later experience 😉

[johnnyreilly]

See my one question; looking good otherwise!

[piotr-oles]

Good job! I hope we can make it consistent across async and sync mode ;)

[codeclimate]

Code Climate has analyzed commit 67200af and detected 0 issues on this pull request.

View more on Code Climate.

[piotr-oles]

Nice! 👍

[robcrocombe]

Thanks @piotr-oles! Some E2E tests are timing out, doesn't seem related to my change. Can we re-run them without pushing a new commit?

[johnnyreilly]

I think I've requeued the tests....

[robcrocombe]

Thanks guys, looking forward to using it :)

[piotr-oles]

🎉 This PR is included in version 5.0.12 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀