Replace uses of os.EOL with grunt.util.linefeed #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a quick look at this tonight. I think the code is fine but I want to do a bit more testing before accepting it. Thanks very much for the contribution and nice first PR. |
nycdotnet
added a commit
that referenced
this pull request
Jan 22, 2015
Replace uses of os.EOL with grunt.util.linefeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I abstracted out the call to grunt.util.linefeed to a single variable in utils.ts to make it easy to maintain later so if grunt were to change the parameter name or if you wanted to make a user option, you would only need to change the code in one place. Besides running all the tests, I also tested it in one of my repos and confirmed I was able to get LF endings when running a grunt-ts task on Windows.