Add support for file names with multiple periods on them. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This looks good. Any chance you can write a test? |
|
Done! Note that compilation will actually fail if you revert 639f5ad so it never gets to the actual test. I added a couple of output checks anyway. Thanks for your quick feedback! |
nycdotnet
added a commit
that referenced
this pull request
May 7, 2015
Add support for file names with multiple periods on them.
|
Well done. Thanks very much. |
nycdotnet
added a commit
that referenced
this pull request
May 7, 2015
nycdotnet
added a commit
that referenced
this pull request
May 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling html files with names containing periods, the compile function creates invalid ts output.
Options used:
Example:
test.view.example.index.html->test.view.example.index.html.tsOutputs
test.view.example.index.html.ts:Which then causes a compile error:
This commit includes a basic fix by replacing all occurrences of
'\.'. Note that it might be a good idea to replace other special js characters.I have too many files with this naming scheme, so a fix would be great. Thank you!