Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GitHub Actions #1144

Merged
merged 18 commits into from
Jul 16, 2020
Merged

update GitHub Actions #1144

merged 18 commits into from
Jul 16, 2020

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Jul 15, 2020

Switched to GitHub Actions.

@g-plane g-plane marked this pull request as ready for review July 16, 2020 04:14
@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

All tests which ran on GitHub Actions passed. AppVeyor and Travis CI won't succeed because I've deleted their configuration files.

@johnnyreilly
Copy link
Member

Nice work!

Could you undelete the Travis and AppVeyor files please? I'd like to run them side by side for a while before decommissioning (though I'll probably not require them to pass before merging; just interested in looking at the difference)

@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

I will.

While this question is not related to this PR, are there any plans for migrating the comparison tests to snapshot tests with Jest?

@johnnyreilly
Copy link
Member

are there any plans for migrating the comparison tests to snapshot tests with Jest?

Great question! I've long pondered doing something like that. It looks like webpack uses jest:

https://github.com/webpack/webpack/blob/master/package.json#L122

I guess the problems to solve here are:

  • the output contains file paths and escaped file paths and similar. That's what all this stuff is about: https://github.com/TypeStrong/ts-loader/blob/master/test/comparison-tests/create-and-execute-test.js#L379 - we'd need a way to perform similar regex voodoo on the jest snapshots
  • the comparison test pack has the concept of "patches". Which means applying a series of changes to the source files so we can trigger the compilation again and harvest output once again. Finding a way (and I'm sure there is) to plug Jest snapshots into that as well.

If you wanted to take a look, we'd greatly appreciate it! 🌻❤️

@g-plane
Copy link
Contributor Author

g-plane commented Jul 16, 2020

Yes, I know. And, can this PR be merged?

@johnnyreilly johnnyreilly merged commit 74bf400 into TypeStrong:master Jul 16, 2020
@johnnyreilly
Copy link
Member

Nice work! Thank you 😄

Assuming all goes well we'll look to drop AppVeyor soon

@g-plane g-plane deleted the github-actions branch July 17, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants