[RFC] fix #270, support appendTsSuffixTo config

[HerringtonDarkholme]

Tests need more handling. Vue loader will produces absolute file path that is path dependent.
And it even produce hash that is machine specific! How can I handle these cases?

Added _flaky mark to vue's test

[johnnyreilly]

Vue loader will produces absolute file path that is path dependent.
And it even produce hash that is machine specific!

Don't worry; our test pack already caters for this

/**
 * replace the hash if found in the output since it can change depending
 * on environments and we're not super interested in it and normalize
 * line endings
 **/
function cleanHashFromOutput(stats, webpackOutput) {
    if (stats) {
        glob.sync('**/*', { cwd: webpackOutput, nodir: true }).forEach(function (file) {
            var content = fs.readFileSync(path.join(webpackOutput, file), 'utf-8')
                .split(stats.hash).join('[hash]')
                .split('\r\n').join('\n');
            fs.writeFileSync(path.join(webpackOutput, file), content);
        });
    }
}

[johnnyreilly]

Is this ready for me to take a look at? I've been holding off until you give me the go-ahead.

[HerringtonDarkholme]

Yes, I have had flaky mark to vue's test. I think as long as the test does not exit with error. It is ok.

The problem is cleanHashFromOutput is solely for output.txt. Vue loader produces filepath in compiled bundle.js.

[HerringtonDarkholme]

Here, the hash code is even emitted in bundle.js

[johnnyreilly]

Ah - in that case we can probably amend the test pack to cater for hashes in the bundle output as well. Actually this is kind of handy as this is the first example of a hot module reloading test in the test pack that I'm aware of. But I can take a look at that later

[johnnyreilly]

Looks good to me 👍

[HerringtonDarkholme]

Thanks!

[johnnyreilly]

My pleasure; I've invited you to join TypeStrong so you'd have commit rights on ts-loader.

In order that we can release I think we just need to do the following:

• update the docs to include details about the new option. Probably worth providing a quick example of how to use this with vuejs for other people to find
• follow the standard instructions here

[johnnyreilly]

Do you fancy handling that? I'd propose that this should become ts-loader v1.1.0

[HerringtonDarkholme]

I think I would provide the doc part. But releasing version goes to you 😉

[johnnyreilly]

That's fine 😄 - let me know when the docs are updated and I'll handle it