Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1130 #1136

Merged
merged 5 commits into from
Oct 31, 2020
Merged

Fix #1130 #1136

merged 5 commits into from
Oct 31, 2020

Conversation

cspotcode
Copy link
Collaborator

Fix #1130

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #1136 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   79.32%   79.60%   +0.28%     
==========================================
  Files           7        7              
  Lines         711      711              
  Branches      158      158              
==========================================
+ Hits          564      566       +2     
+ Misses         90       89       -1     
+ Partials       57       56       -1     
Flag Coverage Δ
node_10 76.28% <ø> (ø)
node_12_15 76.63% <ø> (ø)
node_12_16 76.63% <ø> (ø)
node_13 79.32% <ø> (+0.28%) ⬆️
node_14 79.32% <ø> (+0.28%) ⬆️
node_14_13_0 78.19% <ø> (?)
node_15 79.32% <ø> (+0.28%) ⬆️
typescript_2_7 79.18% <ø> (+0.28%) ⬆️
typescript_latest 78.48% <ø> (+0.28%) ⬆️
typescript_next 78.34% <ø> (+0.28%) ⬆️
ubuntu 79.32% <ø> (+0.28%) ⬆️
windows 79.46% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/esm.ts 84.44% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f7aa1...518d8fa. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 31, 2020

Coverage Status

Coverage increased (+1.03%) to 87.097% when pulling 518d8fa on ab/fix-1130 into a0f7aa1 on master.

@cspotcode cspotcode marked this pull request as ready for review October 31, 2020 23:01
@cspotcode cspotcode merged commit 5f813b1 into master Oct 31, 2020
@cspotcode cspotcode deleted the ab/fix-1130 branch January 18, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM fix for node 14.13.1 breaking change
2 participants