Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls reporting #1149

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Remove coveralls reporting #1149

merged 4 commits into from
Nov 12, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Nov 9, 2020

Before merging, I need to double-check with @blakeembrey to be sure no one else is using the coveralls reporting.

@cspotcode cspotcode marked this pull request as ready for review November 9, 2020 14:29
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1149 (5d1bb79) into master (48fc390) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1149   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files           7        7           
  Lines         711      711           
  Branches      158      158           
=======================================
  Hits          566      566           
  Misses         89       89           
  Partials       56       56           
Flag Coverage Δ
node_10 76.11% <ø> (ø)
node_12_15 76.46% <ø> (ø)
node_12_16 76.46% <ø> (ø)
node_13 78.90% <ø> (ø)
node_14 78.90% <ø> (ø)
node_14_13_0 78.05% <ø> (ø)
node_15 78.90% <ø> (ø)
typescript_2_7 78.90% <ø> (ø)
typescript_latest 78.05% <ø> (ø)
typescript_next 78.05% <ø> (ø)
ubuntu 78.76% <ø> (ø)
windows 78.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fc390...5d1bb79. Read the comment docs.

Copy link
Member

@blakeembrey blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, do you know why everything failed in the tests though?

@cspotcode
Copy link
Collaborator Author

Good catch, seems like I accidentally left a couple lines in the GH Actions workflow that were trying to run an npm script which gets removed by this PR. Removes those lines, I'll double-check that it works.

@cspotcode cspotcode merged commit f848983 into master Nov 12, 2020
@cspotcode cspotcode deleted the ab/remove-coveralls branch January 18, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants