Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest copy-paste of node's ESM resolve implementation #1167

Merged
merged 8 commits into from Dec 1, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Nov 27, 2020

Copy-pasted the latest ESM resolve implementation from node v15.3.0, applied our diff of changes on top of it, and fixed as necessary.

I had to copy a bit more of node's code, and in the process I split it up into more files to keep things organized.

Node's ESM resolver responds to a new --experimental-policy flag, but I disabled it to avoid copy-pasting some policy code. I expect node will stabilize this feature over time, eventually exposing the APIs we need to avoid copy-pasting.

@codecov
Copy link

@codecov codecov bot commented Nov 27, 2020

Codecov Report

Merging #1167 (492b4d4) into master (c11aa8a) will decrease coverage by 0.35%.
The diff coverage is 73.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   79.68%   79.33%   -0.36%     
==========================================
  Files           7       11       +4     
  Lines         709      755      +46     
  Branches      157      157              
==========================================
+ Hits          565      599      +34     
- Misses         89      101      +12     
  Partials       55       55              
Flag Coverage Δ
node_10 76.20% <ø> (ø)
node_12_15 76.55% <ø> (ø)
node_12_16 76.55% <ø> (ø)
node_13 78.67% <73.58%> (-0.31%) ⬇️
node_14 78.67% <73.58%> (-0.31%) ⬇️
node_14_13_0 77.88% <73.58%> (-0.26%) ⬇️
node_15 78.67% <73.58%> (-0.31%) ⬇️
typescript_2_7 78.67% <73.58%> (-0.31%) ⬇️
typescript_latest 77.88% <73.58%> (-0.26%) ⬇️
typescript_next 77.88% <73.58%> (-0.26%) ⬇️
ubuntu 78.54% <73.58%> (-0.31%) ⬇️
windows 78.67% <73.58%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dist-raw/node-primordials.js 50.00% <50.00%> (ø)
dist-raw/node-errors.js 66.66% <66.66%> (ø)
dist-raw/node-internal-fs.js 75.00% <75.00%> (ø)
dist-raw/node-options.js 78.37% <75.00%> (-0.41%) ⬇️
dist-raw/node-package-json-reader.js 84.21% <84.21%> (ø)
dist-raw/node-cjs-loader-utils.js 83.67% <100.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11aa8a...492b4d4. Read the comment docs.

@cspotcode cspotcode merged commit c4a6a02 into master Dec 1, 2020
29 checks passed
@cspotcode cspotcode deleted the ab/update-node-esm-resolve-implementation branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant