Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path mapping support to ESM and CJS loaders #1585

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

Add path mapping support to ESM and CJS loaders #1585

wants to merge 79 commits into from

Commits on Dec 29, 2021

  1. Add path mapping support to ESM loader 

    The ESM loader now resolves import paths using TypeScripts [path
mapping][1] feature.

[1]: https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
    @geigerzaehler
    geigerzaehler committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    3be1fde View commit details
    Browse the repository at this point in the history

  2. fixup! Add path mapping support to ESM loader

    @geigerzaehler
    geigerzaehler committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    c542d98 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. fixup! fixup! Add path mapping support to ESM loader

    @geigerzaehler
    geigerzaehler committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    0cbfa6c View commit details
    Browse the repository at this point in the history

  2. fixup! fixup! fixup! Add path mapping support to ESM loader

    @geigerzaehler
    geigerzaehler committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    e7082b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Merge remote-tracking branch 'origin/main' into path-mapping

    @cspotcode
    cspotcode committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    69a397b View commit details
    Browse the repository at this point in the history

  2. address code review comments 

    Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
    @geigerzaehler
    geigerzaehler committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    2fcb982 View commit details
    Browse the repository at this point in the history

  3. map esm paths in all included files 

    Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
    @geigerzaehler
    geigerzaehler committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    48f5262 View commit details
    Browse the repository at this point in the history

  4. improve error message when mapped module is not found 

    Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
    @geigerzaehler
    geigerzaehler committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a19454b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Review changes; add CommonJS path mapping

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    32e26e8 View commit details
    Browse the repository at this point in the history

  2. fix failing tests

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    362935b View commit details
    Browse the repository at this point in the history

  3. add path mapping to docs

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    e573fd7 View commit details
    Browse the repository at this point in the history

  4. add flag to enable/disable path mapping in the two loaders

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    0012b22 View commit details
    Browse the repository at this point in the history

  5. fix windows tests?

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    b6352e3 View commit details
    Browse the repository at this point in the history

  6. fix windows tests?

    @cspotcode
    cspotcode committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    85643fd View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Merge remote-tracking branch 'origin/main' into path-mapping

    @cspotcode
    cspotcode committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    9c46688 View commit details
    Browse the repository at this point in the history

  2. add path mapping option to docs

    @cspotcode
    cspotcode committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    bede1b6 View commit details
    Browse the repository at this point in the history

  3. changes

    @cspotcode
    cspotcode committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    80746c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. replace equal (deprecated) with strictEqual

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    885b7b1 View commit details
    Browse the repository at this point in the history

  2. extract shared tsconfig

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    c3dbe73 View commit details
    Browse the repository at this point in the history

  3. move import targets 2-deep (to support combined baseUrl + * path)

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    8c5fd23 View commit details
    Browse the repository at this point in the history

  4. test: baseUrl + no paths

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    e66d236 View commit details
    Browse the repository at this point in the history

  5. test: baseUrl + * path

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    23f40b1 View commit details
    Browse the repository at this point in the history

  6. test: fallback to node_modules

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    54fdbba View commit details
    Browse the repository at this point in the history

  7. clean up destructuring

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    78652b2 View commit details
    Browse the repository at this point in the history

  8. fix setting project

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    b8e6fb7 View commit details
    Browse the repository at this point in the history

  9. test: fallback to built-in

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    2973399 View commit details
    Browse the repository at this point in the history

  10. avoid space in command & add comment

    @charles-allen
    charles-allen committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    5ffd905 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2022

  1. fix setting project and PATH

    @charles-allen
    charles-allen committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    d200301 View commit details
    Browse the repository at this point in the history

  2. test: skip type-defs

    @charles-allen
    charles-allen committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    c621af0 View commit details
    Browse the repository at this point in the history

  3. test: external imports ignore paths

    @charles-allen
    charles-allen committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    ec038c1 View commit details
    Browse the repository at this point in the history

  4. tests: relative/base-relative imports ignore paths

    @charles-allen
    charles-allen committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    d471d1d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Merge remote-tracking branch 'origin/main' into path-mapping

    @cspotcode
    cspotcode committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    d5728dc View commit details
    Browse the repository at this point in the history

  2. Updates

    @cspotcode
    cspotcode committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    5b686e1 View commit details
    Browse the repository at this point in the history

  3. add missing package.json from node_modules

    @cspotcode
    cspotcode committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    cb3706e View commit details
    Browse the repository at this point in the history

  4. rolling back a config change; I was wrong

    @cspotcode
    cspotcode committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    d00bf73 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. add helper execEsm(...)

    @charles-allen
    charles-allen committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    398db86 View commit details
    Browse the repository at this point in the history

  2. test: decouple base-url-no-paths test (by extracting it)

    @charles-allen
    charles-allen committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    a91d5d7 View commit details
    Browse the repository at this point in the history

  3. test: decouple skip-type-definition test (by extracting it)

    @charles-allen
    charles-allen committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    7829b54 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. test: refactor to apply tests across multiple module types & project … 

    …configs
    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    9fd944e View commit details
    Browse the repository at this point in the history

  2. temporarily move old tests out of the way

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    4e0d363 View commit details
    Browse the repository at this point in the history

  3. test: refactor again to restore shared examples/node_modules (while m… 

    …aintaining test reuse)

...this is still a bit WIP...
    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    09cc514 View commit details
    Browse the repository at this point in the history

  4. import assert async so we can assert pre-conditions (& so sut impor… 

    …t fails first)
    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    70d9bf5 View commit details
    Browse the repository at this point in the history

  5. sync tsconfigs

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    e50abd4 View commit details
    Browse the repository at this point in the history

  6. fix error message in import-node-built-in (it's not a precondition)

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    73d6acc View commit details
    Browse the repository at this point in the history

  7. try to clean up cjs imports :/

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    d02cbed View commit details
    Browse the repository at this point in the history

  8. simplify tests

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    283309d View commit details
    Browse the repository at this point in the history

  9. test: restore "ignore type definition" tests

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    f2e2f65 View commit details
    Browse the repository at this point in the history

  10. delete obsolete examples

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    93ac2ac View commit details
    Browse the repository at this point in the history

  11. fix star paths

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    bf7bfcd View commit details
    Browse the repository at this point in the history

  12. move old tests a bit more out of the way

    @charles-allen
    charles-allen committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    c26b9dd View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Merge remote-tracking branch 'origin/main' into path-mapping

    @cspotcode
    cspotcode committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    09ebf63 View commit details
    Browse the repository at this point in the history

  2. ensure ts-node is installed before running tests

    @cspotcode
    cspotcode committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    e0af738 View commit details
    Browse the repository at this point in the history

  3. disable typechecking in tests

    @cspotcode
    cspotcode committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    31acd50 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. test: add a case that imports an esm lib from node_modules

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    36377fc View commit details
    Browse the repository at this point in the history

  2. use require everywhere in cjs examples

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    56ef378 View commit details
    Browse the repository at this point in the history

  3. destructure import proxyLodash; align both depends-on-lodash deps as cjs

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4dcff42 View commit details
    Browse the repository at this point in the history

  4. fix baseUrl

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    ba176bf View commit details
    Browse the repository at this point in the history

  5. revert assertions to use expect(err).toBeNull(); Clean up config cons… 

    …tants
    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    38ad3f5 View commit details
    Browse the repository at this point in the history

  6. prefer function declaration to arrow function

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    1687de9 View commit details
    Browse the repository at this point in the history

  7. move base 2 deep, so star path can be used in addition to base

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8e9b117 View commit details
    Browse the repository at this point in the history

  8. tests: non-relative imports

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    806ce74 View commit details
    Browse the repository at this point in the history

  9. fix import extensions

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0fd8a5c View commit details
    Browse the repository at this point in the history

  10. tests: imports from js, jsx, tsx

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    02818e3 View commit details
    Browse the repository at this point in the history

  11. rename under-base to below-base (nicer lexical sort)

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    6faedd9 View commit details
    Browse the repository at this point in the history

  12. tests: relative imports

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    64bb679 View commit details
    Browse the repository at this point in the history

  13. tests: import invalid path

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    058d2e2 View commit details
    Browse the repository at this point in the history

  14. test: should not use star-path to resolve relative import

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4a3b6b4 View commit details
    Browse the repository at this point in the history

  15. tests: basic path mapping

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    dc7e950 View commit details
    Browse the repository at this point in the history

  16. fix import style

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c5ea9b0 View commit details
    Browse the repository at this point in the history

  17. tests: map using first available candidate

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    7bfe31a View commit details
    Browse the repository at this point in the history

  18. tests: more specific path; static path

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c8c35ca View commit details
    Browse the repository at this point in the history

  19. comment out file-system-base-relative import

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    99ca516 View commit details
    Browse the repository at this point in the history

  20. tests: mapping from js, jsx, tsx files

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4fefc57 View commit details
    Browse the repository at this point in the history

  21. clean up (delete all old tests)

    @charles-allen
    charles-allen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    3a0067e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. tweaks before pulling in the latest main branch

    @cspotcode
    cspotcode committed May 18, 2022
    Configuration menu
    Copy the full SHA
    78e3eda View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into path-mapping

    @cspotcode
    cspotcode committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4f5bc35 View commit details
    Browse the repository at this point in the history

  3. fix

    @cspotcode
    cspotcode committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ef926b9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. style tweak

    @cspotcode
    cspotcode committed May 19, 2022
    Configuration menu
    Copy the full SHA
    7552fc4 View commit details
    Browse the repository at this point in the history

  2. turn on experimental resolver; add required file extensions to esm tests

    @cspotcode
    cspotcode committed May 19, 2022
    Configuration menu
    Copy the full SHA
    6632481 View commit details
    Browse the repository at this point in the history