Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow importing types via typescript #24

Closed
wants to merge 1 commit into from
Closed

Allow importing types via typescript #24

wants to merge 1 commit into from

Conversation

ForbesLindesay
Copy link

Without this, typescript can't see the definition files exported by this library.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.254% when pulling da0d37b on ForbesLindesay:patch-1 into 6eba326 on TypeStrong:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.254% when pulling da0d37b on ForbesLindesay:patch-1 into 6eba326 on TypeStrong:master.

@blakeembrey
Copy link
Member

We should switch from Typings to @types before we do this though: https://github.com/TypeStrong/tsconfig/blob/master/typings.json.

@ForbesLindesay
Copy link
Author

I'll leave that change to you.

@blakeembrey blakeembrey mentioned this pull request Aug 28, 2017
Merged
@ForbesLindesay ForbesLindesay deleted the patch-1 branch September 6, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForbesLindesay @coveralls @blakeembrey