Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check real fs case sensitivity #201

Closed
wants to merge 2 commits into from
Closed

Conversation

koroandr
Copy link

@koroandr koroandr commented Oct 3, 2016

Fix for #200

I used fs-file-name-sensitive module to check the case sensitivity on some file (__filename in Host.js). It simply checks, if we change filename to upper case, would it be opened.

The solution is not so elegant, but works fine for me.

@koroandr koroandr changed the title Fix issue #200 - check real fs case sensitivity #200 - check real fs case sensitivity Oct 3, 2016
@koroandr koroandr changed the title #200 - check real fs case sensitivity Check real fs case sensitivity Oct 3, 2016
@cartant
Copy link
Contributor

cartant commented Oct 3, 2016

I'm closing this, as I've merged a change that should detect case sensitivity without using the fs-file-name-sensitive module. I'd prefer not to add a dependency unless absolutely necessary and I'm not especially keen on that module's implementation, as it creates and removes a temporary file.

If you could verify that the current master solves your problem, I'll publish a new version to NPM.

@cartant cartant closed this Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants