This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
Add hideShowToolbar() to onScroll() #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit0
suggested changes
Oct 19, 2019
|
Code looks good, but I need to pull this down & build with a few projects to test it. I'll try to get to it this week, or next weekend at the latest. |
|
Looks, great. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolbar will hide and show as you scroll up and down. One quibble is that it obscures a bit of text on the side navigation menu.
Edit: I fixed the obscuring. The secondary nav now resizes when needed on scroll.
Edit 2: I noticed that the search results don't go away if you scroll. I think maybe the toolbar should remain visible if there are search results. I'll look into it.