Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 supported config paths do not work in 0.14.0 #942

Closed
1 task done
Roaders opened this issue Jan 10, 2019 · 3 comments · Fixed by #944
Closed
1 task done

0.13 supported config paths do not work in 0.14.0 #942

Roaders opened this issue Jan 10, 2019 · 3 comments · Fixed by #944
Labels
bug Functionality does not match expectation

Comments

@Roaders
Copy link
Contributor

Roaders commented Jan 10, 2019

Expected Behavior

My --options path is:

node_modules/my-config-project/config/typedoc.config.json

in 0.13 this worked fine

Actual Behavior

In 0.14 this no longer loads the config, This makes 0.14 a breaking change despite not being marked as such and has broken 60+ projects...

Environment

  • Typedoc version: 0.14
  • Node.js version: 8.11.1
  • OS: windows
@Roaders Roaders added the bug Functionality does not match expectation label Jan 10, 2019
@aciccarello
Copy link
Collaborator

What CLI string are you using to invoke TypeDoc? Are you specifying the input files in a file or just the --options argument?

I think this may be the same as #604 (comment). I closed that issue but as I think about it more that case should be working. We'll take a look at the argument parsing and we should be able to fix this in a patch release.

@pamls
Copy link

pamls commented Jan 10, 2019

Same behavior with --tsconfig. An error is thrown since version 0.14. Version 0.13 is working.
Argument: --tsconfig tsconfig.production.json

Error: The tsconfig file does not exist.

Gerrit0 added a commit that referenced this issue Jan 10, 2019
aciccarello pushed a commit that referenced this issue Jan 11, 2019
* Don't limit option files to standard names

Fixes #942
@aciccarello
Copy link
Collaborator

aciccarello commented Jan 11, 2019

To clarify the source of this bug, typedoc was too strict when testing for a file name so files that did not match typedoc.js[on] or tsconfig.json were not accepted. This has been fixed in the

This has been fixed in the v0.14.1 release

@aciccarello aciccarello changed the title 0.13 supported config paths do not work in 0.14 0.13 supported config paths do not work in 0.14.0 Jan 11, 2019
@aciccarello aciccarello unpinned this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants