Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emitDeclarationOnly to ignored tsconfig options #1104

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Add emitDeclarationOnly to ignored tsconfig options #1104

merged 1 commit into from
Oct 12, 2019

Conversation

henrymyers
Copy link

@henrymyers henrymyers commented Oct 3, 2019

As mentioned by @brainkim and confirmed by @aciccarello in issue 811, specifying the emitDeclarationOnly option in your tsconfig file causes typedoc to fail.

This PR fixes the problem by adding emitDeclarationOnly to the list of ignored tsconfig options.

Bonus: Fixed an incorrect command specified in the Contributors file.

@Gerrit0 Gerrit0 merged commit 297e13d into TypeStrong:master Oct 12, 2019
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 12, 2019

Thanks!

@henrymyers
Copy link
Author

@Gerrit0 would it be possible to get a patch version bump? This fixes an issue on another repo, and it would be cleaner to point to an actual version rather than a commit.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 15, 2019

I don't have publishing permissions on the main repo - @aciccarello can do that though.

I keep @gerrit0/typedoc even with the master branch here though, so you could point your dependencies there until we have a release here.

@henrymyers
Copy link
Author

For the moment I'm directly pointing to the commit after my PR was merged into master.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 13, 2019

This has been published in 0.15.1 :)

@henrymyers
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants