Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger extensions now also count the warnings #1210

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Logger extensions now also count the warnings #1210

merged 1 commit into from
Feb 22, 2020

Commits on Feb 18, 2020

  1. Logger extensions now also count the warnings 

    I cannot believe I messed up that previous PR (TypeStrong#1205), but the extensions of the `Logger` class did not count the warnings.
Solved this by removing the error counting code from the child classes, and called the super method instead.
This ensures that both the error count and the warning count increases.
    @PissedCapslock
    PissedCapslock committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    8f65cf0 View commit details
    Browse the repository at this point in the history