-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump marked from 3.0.8 to 4.0.10 #1851
Merged
Gerrit0
merged 2 commits into
TypeStrong:master
from
stefanobaghino-da:bump-to-marked-4.0.10
Jan 18, 2022
Merged
Bump marked from 3.0.8 to 4.0.10 #1851
Gerrit0
merged 2 commits into
TypeStrong:master
from
stefanobaghino-da:bump-to-marked-4.0.10
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates at superseding TypeStrong#1844 by bumping to a more recent `@types/marked` and fixing where breaking changes happened. Bumps [marked](https://github.com/markedjs/marked) from 3.0.8 to 4.0.10. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json) - [Commits](markedjs/marked@v3.0.8...v4.0.10)
stefanobaghino-da
added a commit
to digital-asset/daml
that referenced
this pull request
Jan 17, 2022
A couple of fixes on top of #12443: - unpin the node-forge 0.10.0 resolution to remove it from our lockfile - remove the useless scoped resolution for marked For the latter, the transitive dependency breaks between 3.x and 4.x so the problem is not easily solved without `typedoc` maintainers publishing a fixed version. I opened a PR here: TypeStrong/typedoc#1851 changelog_begin changelog_end
7 tasks
Mmmh, looks like I should fix the lockfile, having a look (apologies, I'm not particularly expert in |
Fixed by d959b71 |
Thanks! |
stefanobaghino-da
added a commit
to digital-asset/daml
that referenced
this pull request
Jan 18, 2022
A couple of fixes on top of #12443: - unpin the `self-signed` resolution to remove the transitive dependency on `node-forge` 0.10.0 - upgrades `typedoc` to 0.22.11 after TypeStrong/typedoc#1851 got merged to remove the transitive dependency on `marked` 3.x changelog_begin changelog_end
Many thanks for accepting the PR and immediately making a new release! 🙇🏻♂️ |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts at superseding #1844
by bumping to a more recent
@types/marked
and fixing where breakingchanges happened.
Bumps marked from 3.0.8 to 4.0.10.