Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propertyType doc improvements #840

Merged
merged 1 commit into from
Jun 7, 2020
Merged

fix: propertyType doc improvements #840

merged 1 commit into from
Jun 7, 2020

Conversation

psicomante
Copy link
Contributor

Informations

Type Breaking change
Fix No

Description

Hi @Romakita, tsed is a great project, thank you to allow us to use it!
Some weeks ago i was building an express-based project with Typescript, trying to have a similar experience to many MVC frameworks like Spring Boot, adding TypeOrm, DI, Services, AutoMapper and Swagger integration; then i found tsed and it's exactly the project i would like to build! Thank you indeed.

Following the example of #719 i made some minor linguistic improvements to the Property Type documentation. I'm italian, so my english skill could be not be the best available around here, but I believe the changes make the point more clear.

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Romakita
Copy link
Collaborator

Romakita commented Jun 7, 2020

Thanks @psicomante for your first PR :)

Your help is welcome ;). If you find another typo or issue about our framework don't hesitate :)

See you ;)

@Romakita Romakita merged commit ac64b8c into tsedio:production Jun 7, 2020
@psicomante psicomante deleted the feature/minor-doc-improvements branch June 7, 2020 09:36
@psicomante
Copy link
Contributor Author

I'm using it massively for a hobby project, i hope to improve it soon! Thank you again! see you.

@Romakita
Copy link
Collaborator

Romakita commented Jun 7, 2020

🎉 This PR is included in version 5.57.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants