Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TU-9756): support no-scrollbars flag #644

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

PabloMDiez
Copy link
Contributor

Hi there! This piece of work intends to fix a glitch that can be observed with the following conditions:

  • Windows OS (seem to always render very thick scrollbars)
  • Chromium browsers
  • autoResize on

When changing the parent window width, the typeform will recalculate sizes and word-wrapping, which can get the user in the following loop:

  • Width changed
  • Text elements in view cannot fit: some elements are moved to a new line
  • Scrollbars are rendered immediately
  • Width changes again (scrollbars are occupying space in view)
  • If embed's height is smaller than the current block: resize
  • Upon resize: scrollbars are no longer needed
  • Scrollbars disappear
  • Text can now fit with the extra width they now get: a newline is not needed
  • Height changes: embed resizes

In some cases, this is reproducible in Chrome over Mac as well, but I got the worst glitch testing it in Windows 10 w/Chromium 122 & derivatives

@PabloMDiez PabloMDiez requested a review from a team as a code owner March 14, 2024 08:28
@typeform-ops-gha
Copy link

[BOT] Preview available with hash b2acf2cd4e7258653246d21563d2d1df952eb12d here.

@PabloMDiez PabloMDiez merged commit c7d8e70 into main Mar 18, 2024
10 checks passed
@PabloMDiez PabloMDiez deleted the TU-9756/embed-no-scrollbars branch March 18, 2024 11:23
typeform-ops-gha pushed a commit that referenced this pull request Mar 18, 2024
# [@typeform/embed-v4.9.0](https://github.com/Typeform/embed/compare/@typeform/embed-v4.8.1...@typeform/embed-v4.9.0) (2024-03-18)

### Features

* **TU-9756:** support no-scrollbars flag ([#644](#644)) ([c7d8e70](c7d8e70))
@typeform-ops-gha
Copy link

🎉 This PR is included in version @typeform/embed-v4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants