feat(NOJIRA-123): update form.settings type to have all options

[gurpreetatwal]

I got the list of defaults by creating a new form using the API and inspecting the response as some of the options were not listed on the docs / had different names vs what was specified on the docs.

I also reordered the options to match the API response order.

Added:

• are_uploads_public
• autosave_progress (docs have this as autocomplete_progress)
• free_form_navigation
• hide_navigation
• pro_subdomain_enabled
• show_cookie_consent
• show_key_hint_on_choices
• show_number_of_submissions
• show_question_number
• show_time_to_complete
• use_lead_qualification

Reordered:

• language
• is_public
• progress_bar
• show_progress_bar
• show_typeform_branding

[mathio]

Hello @gurpreetatwal thank you for the PR. It looks good, I have just one question - where did you get the "default" values from? If I am not mistaken, if the field is not present then the default value should be false.

[gurpreetatwal]

Hi @mathio, thank you for the quick reply! I pulled the default value from the API response after creating a new form (e.g. create a form using the API with no options set and then inspect the response from the corresponding GET request). In that sense the defaults I documented might "go too far" in that they're listing the default behavior of Typeform and not the interface specifically.

Happy to change the defaults to undefined if the aim is to document the default of the interface itself

[mathio]

Thanks. I talked to my team mates and we think an undefined as a default is fine, as this is "going too far" 👍

[gurpreetatwal]

Sounds good! In terms of documentation which of the following should I do?

1. Remove the default mention entirely
2. Update default to be undefined
3. Update default to be "" (matches convention in rest of file)

[mathio]

I think you can match the current convention.

[typeform-ops-gha]

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀