Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-client): remove need for token #47

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Conversation

MichaelSolati
Copy link
Contributor

Removes need for passing in token when constructing client, that way simple tasks like fetching public forms are easy. If a request requires a token, then the request would fail and the user would need to catch the failed request (which usually says a token is needed).

@MichaelSolati MichaelSolati added the enhancement New feature or request label Oct 10, 2019
@picsoung
Copy link
Contributor

nice one!

I wonder if we could warn the user earlier, and not avoid making API calls that we know will be failing for sure.

Currently, I think there are only a few endpoints that don't require authentication, /forms/{form_id} and /themes/{theme_id}

Could not there be a logic to accept a client with empty tokens for those endpoints and fail in any other case?

Copy link

@anabellaspinelli anabellaspinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@anabellaspinelli
Copy link

@picsoung not sure what you mean 🤔

When exactly would you warn users? I don't think we can know what they'll use the client for when they're just instantiating it.

@travis-tf
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants