Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of complex propTypes spoils the syntax #89

Closed
boonya opened this issue Feb 12, 2021 · 2 comments
Closed

Sorting of complex propTypes spoils the syntax #89

boonya opened this issue Feb 12, 2021 · 2 comments

Comments

@boonya
Copy link

boonya commented Feb 12, 2021

2021-02-12 18 20 42

The initial state

	id: PropTypes.string.isRequired,
	title: PropTypes.string.isRequired,
	video: PropTypes.shape({
		en: PropTypes.string.isRequired,
		fr: PropTypes.string.isRequired,
	}).isRequired,
	onClick: PropTypes.func.isRequired,

Expected result

	id: PropTypes.string.isRequired,
	onClick: PropTypes.func.isRequired,
	title: PropTypes.string.isRequired,
	video: PropTypes.shape({
		en: PropTypes.string.isRequired,
		fr: PropTypes.string.isRequired,
	}).isRequired,

Actual result

		en: PropTypes.string.isRequired,
		fr: PropTypes.string.isRequired,
	}).isRequired,
	id: PropTypes.string.isRequired,
	onClick: PropTypes.func.isRequired,
	title: PropTypes.string.isRequired,
	video: PropTypes.shape({
@Tyriar
Copy link
Owner

Tyriar commented May 25, 2021

Sorting requiring language smarts is out of scope for this extension

@Tyriar Tyriar closed this as completed May 25, 2021
@boonya
Copy link
Author

boonya commented May 25, 2021

Fair enough. Thank you for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants