Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative menu layout: use sub-menu for profile selection to avoid extra click #5

Open
mback2k opened this issue Jun 5, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@mback2k
Copy link

mback2k commented Jun 5, 2020

I would like to suggest an alternative or maybe even additional menu layout.

Instead of clicking on the command and then getting prompted for profile selection, the main menu entry could already contain a nested profile selection sub-menu.

This could either be configurable in the extension settings or co-exist with the main menu action.

@Tyriar Tyriar added the enhancement New feature or request label Jun 5, 2020
@Tyriar
Copy link
Owner

Tyriar commented Jun 5, 2020

Sub-menu aren't possible atm in extensions, the feature request is microsoft/vscode#9827

I'm not that familiar with the context menu API, we should be able to create a list but I think it might be possible to use a setting to change the layout to inline several profiles though, maybe that would be good enough? I believe they have to be statically declared at the start though, including the title of the menu item.

Currently we have:

Open in Windows Terminal

But a settings like this:

"windowsTerminal.inlineProfile1": "PowerShell",
"windowsTerminal.inlineProfile2": "WSL"

Could enable:

Open in Windows Terminal (Profile 1)
Open in Windows Terminal (Profile 2)

Alternatively we could whitelist the common/default profile names, these titles would need to be hardcoded though, not dynamically assigned in the settings:

eg.

"windowsTerminal.inlinePowershell": true,

Could enable:

Open in Windows Terminal (PowerShell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants