Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display reaction authors #133

Closed
Miepee opened this issue Jan 20, 2019 · 7 comments
Closed

Display reaction authors #133

Miepee opened this issue Jan 20, 2019 · 7 comments

Comments

@Miepee
Copy link

Miepee commented Jan 20, 2019

It'd be nice to see, from which user(s) the reactions come from.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jan 21, 2019

This looks like it's impossible to do with the API because it doesn't return reaction authors
https://discordapp.com/developers/docs/resources/channel#reaction-object

@Miepee
Copy link
Author

Miepee commented Jan 22, 2019

Oh, well then.
I'll just hope, that the API gets updated sometime, to make that possible.

@Throne3d
Copy link

The API lets you get the reaction authors, if you give it a channel, a message, and the relevant emoji: https://discordapp.com/developers/docs/resources/channel#get-reactions. I'm not sure if this would be too much overhead in terms of separate requests for the data?

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jan 23, 2019

Hm, this is 1 call per each reaction emoji per each message, that would a lot of requests. I guess Discord itself queries this every time you hover over specific reaction.

@Tyrrrz Tyrrrz added the wontfix label Feb 9, 2019
@Tyrrrz
Copy link
Owner

Tyrrrz commented Feb 9, 2019

Marking as "wontfix" because of the issue @Throne3d mentioned. Discord queries reaction authors on per-message basis, knowing that it won't need to get it for all messages in the channel. DiscordChatExporter, on the other hand, will have to do it for all messages, which will make it more expensive in terms of time than it's worth.

@omegasome
Copy link

omegasome commented Mar 2, 2022

@Tyrrrz Why would it have to do it for every single message?

Obviously DCE knows which messages have reactions and even which emoji they are—that's how it knows to display them on a message in the export.

So why couldn't it query who reacted to a message when (and only when) it knows someone did? Is there something I'm missing here? Maybe about the structure of this particular program?

@TheTechRobo
Copy link

@omegasome Late response but in big servers, especially announcement channels, that might blow up to hundreds of requests. That's not terribly efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@Throne3d @Tyrrrz @Miepee @TheTechRobo @omegasome and others