Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for not reporting empty test assemblies #26

Merged
merged 3 commits into from
May 29, 2024

Conversation

Mpdreamz
Copy link
Contributor

@Mpdreamz Mpdreamz commented May 29, 2024

We use --filter to selectively run test assemblies in different runs.

This produces somewhat noisy reports where assemblies are marked as (failed/succeeded) and skipped multiple times:

https://github.com/elastic/apm-agent-dotnet/actions/runs/9275127823?pr=2315#summary-25519083669

This PR now differentiates assemblies with no tests from assemblies with skipped tests using ⚪️. It also introduces an option to not report test assemblies without any tests (defaults still is to so).

@Tyrrrz Tyrrrz added the enhancement New feature or request label May 29, 2024
Readme.md Outdated Show resolved Hide resolved
@Tyrrrz
Copy link
Owner

Tyrrrz commented May 29, 2024

Thanks for the PR, it's very clean 🙂

@Tyrrrz Tyrrrz merged commit f3ad827 into Tyrrrz:master May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants