Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Win10 update to 1903 broke this app #100

Closed
Win10pissesmeoff opened this issue Jun 12, 2019 · 55 comments
Closed

The new Win10 update to 1903 broke this app #100

Win10pissesmeoff opened this issue Jun 12, 2019 · 55 comments
Labels

Comments

@Win10pissesmeoff
Copy link

Win10pissesmeoff commented Jun 12, 2019

Never had any issues before but after this Windows 10 update to 1903 this app doesn't work at all anymore. Not sure if there is an setting to fix this but figured you'd want to know about it.

Edit- After doing a bit more searching I found a fix on this page https://answers.microsoft.com/en-us/windows/forum/all/windows-10-1903-may-update-breaks-night-light/75f21187-07ff-4c3d-b552-f390f205db67?auth=1

I had slightly different files other than what was listed but I found 2 by ctrl+F "windows.data.bluelightreduction" and deleted that one and "windows.data.bluelightreduction.settings"

I restarted and it seems to be working again. Will update if the problem persists.

@dolevu
Copy link

dolevu commented Jun 12, 2019

It worked for me after deleting the registry keys also

@dolevu
Copy link

dolevu commented Jun 13, 2019

In my case, the first restart, it works. Then it breaks after second restart, I have to delete the registry keys again

@dolevu
Copy link

dolevu commented Jun 13, 2019

After installing Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293)
The problem fixed.

@scarystuff
Copy link

I have the Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293) and it's not fixed for me :-/

@dolevu
Copy link

dolevu commented Jun 15, 2019

@scarystuff my LightBulb and Windows Night Mode stopped working today. So the issue is windows update itself, the problem still persists

@TacosAreYum
Copy link

Broken on 1903 for me too.

@Win10pissesmeoff
Copy link
Author

Not sure if anyone else is still having issues, but I had it not work once after a reset. I just deleted the 2 registry files again and it seems to be working as intended now after resetting multiple times. This is on the Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293).

@dolevu
Copy link

dolevu commented Jun 22, 2019

@Win10pissesmeoff I deleted the registry keys, but after restarting, the problem comes back.
Right now I only sleep the computer, not shutting down so I won't have to delete the registry keys again and again.

@Win10pissesmeoff
Copy link
Author

The problem comes back for me if I shut down my PC but I usually just keep it on sleep so that's why it wasn't resetting for me. Not sure how to fix other than deleting the registry files after every shut down.

@dolevu
Copy link

dolevu commented Jun 29, 2019

Finally it's fixed
https://support.microsoft.com/en-us/help/4501375/windows-10-update-kb4501375

@broizter
Copy link

Still not fixed after installing kb4501375 for me.

@dolevu
Copy link

dolevu commented Jul 1, 2019

I can confirm it's still working for me after many times restarting.
Maybe you should try to delete the registry keys mentioned above @broizter?

@SethBergen
Copy link

Not working for me either on the latest cumulative update (KB4507453).
Any deleted keys reappear on restart.

@broizter
Copy link

broizter commented Jul 23, 2019

Enabling or disabling multi-monitor in Windows fixes the problem temporarily until next scheduled color shift.

@Jefferderp
Copy link

Jefferderp commented Jul 23, 2019

Enabling or disabling multi-monitor in Windows fixes the problem temporarily until next scheduled color shift.

I just tested, and this is true for me as well. Updating to the latest (KB4507453) made no difference, but Lightbulb immediately began working once I disconnected all but my primary monitor.

@Tyrrrz, it appears the issue with color temperature not changing is caused by multiple displays, ever since Windows 1903.

@starsoccer
Copy link

+1 same issue, disabling multi-monitor fixes it.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jul 28, 2019

Looks like Windows broke something with this update. The fact that it affects only multi-monitor setup leads me to think they changed something related to how the GetDC native function works with null pointer (which used to mean "all monitors").

I'll try to figure out if there's a workaround as soon as I have some time.

@MariusSp
Copy link

MariusSp commented Oct 8, 2019

Any news on this front?

@Tyrrrz
Copy link
Owner

Tyrrrz commented Oct 8, 2019

Working on it. Making some large changes in #105 which should hopefully enable tackling this issue.

@Dainius14
Copy link

Dainius14 commented Nov 2, 2019

As of af48000 seems to be working fine in Windows 10 build 18362.418

@Dainius14
Copy link

Unfortunately, does not work on multi-monitor setup. At least works when only single monitor is used. Previous version did not work for single or multi monitor setup.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

@Dainius14 just to clarify, "does not work on multi-monitor setup" means that neither of the two monitors' gamma change? or does it mean only primary monitor is affected but the other monitors stay the same?

@starsoccer
Copy link

I think it means both, I briefly tested it a few days ago and couldnt notice any change

@Dainius14
Copy link

Dainius14 commented Nov 11, 2019 via email

@Tyrrrz Tyrrrz closed this as completed in 61927b3 Nov 11, 2019
@Dainius14
Copy link

Tried it now.

Does not work :( Nothing happens on multi-monitor setup

@starsoccer
Copy link

I used the portable version(not installer)

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

@Dainius14 try this one https://github.com/Tyrrrz/LightBulb/commit/9018e191f2c36c501566ad111c8ca64c3cc9d2e7/checks?check_suite_id=305727114
I've switched to a different approach for grabbing DC, hope it helps. Unfortunately I don't have a second monitor nor Win10 1903 to test.

@Dainius14
Copy link

Great work! It's working!

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

Sweet :)

@Tyrrrz Tyrrrz closed this as completed in b8df79a Nov 11, 2019
@starsoccer
Copy link

@Dainius14 Did you use the portable or installer? Portable for me is still not starting.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

Fix is in master, build is here, please test this on both single monitor and multi-monitor setups. And if you have access to Win7, Win8, Win8.1, it would be nice to test on them too.

CC @mirh @NomDeMorte @aure2006 if you guys can help test the latest build.

@starsoccer
Did you unpack all of the files to a separate directory? Does it say anything at all or just quietly does nothing? Do you remember which was the last build that worked?

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

@starsoccer
Copy link

Giving it a try now, but I dont think thats the issue. Mainly because my other portable install, 1.6.4.1 starts fine. So unless this is a new requirement I dont think its related.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

Yes, it's new in 2.0

@starsoccer
Copy link

Nice that worked, would be useful to have that as an error popup. Like if its not found to show an error saying both are needed

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 11, 2019

I will include a notice on release page when 2.0 is released

@NomDeMorte
Copy link

Seems to be working here, on both monitors - although I'm still on 1809 so I'm not sure if this is of any relevance.... at least, the change didn't break old versions ;)

@spacecheese
Copy link
Contributor

I couldn't get this to work on 1903. I just updated to 1909 and it still doesn't seem to be working on either monitor. Windows night light doesn't seem to do anything either.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

@spacecheese what interface are your monitors connected with? Does f.lux not work either?

@spacecheese
Copy link
Contributor

@Tyrrrz my monitors are connected to a gtx 970, f.lux seems to work fine though I'll try an update my graphics drivers and see if that makes any difference.

@ChrisLMerrill
Copy link

I've also updated to 1909 today and there is no change in LightBulb functionality (or f.lux).

@spacecheese
Copy link
Contributor

New drivers didn't seem to make any difference.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

@spacecheese I mean, are you using DisplayLink dock connect by any chance?

@spacecheese
Copy link
Contributor

@Tyrrrz not using anything like that. My monitors are directly connected to the graphics card outputs.

@spacecheese
Copy link
Contributor

Appologies. I've resolved my issue- it seems that the display drivers that TeamViewer installs don't support gamma ramps so that SetDeviceGammaRamp was failing.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

@spacecheese
Hmm, that's weird, although nice that it was resolved. How does it work, TeamViewer just installs display drivers that replace your GPU's drivers? Or were you connected to another computer through TeamViewer and had LightBulb installed there?

@spacecheese
Copy link
Contributor

Teamviewer has an optional monitor driver that replaces the Windows "Generic PnP" one so that you can draw pictures over the screen. Pretty annoying to track down.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

Good to know. We should probably have a list of known issues like this.

Edit: apparently there already was a wiki page from 2017 lol. https://github.com/Tyrrrz/LightBulb/wiki/Troubleshooting

@ChrisLMerrill
Copy link

FWIW, I do occasionally use a MS Teams conferencing project, can't recall if it is called TeamViewer, but that sounds familiar. I don't install the full version - just the one-time download when joining a meeting. I can't tell if it has mucked with my driver or not. Or if f.lux would be similarly affected by that?

On a separate note, I've also confirmed that I do not have a DisplayLink driver installed (as described in the link from the Troubleshooting page). That's what I would expect since I'm using DVI via my dock, but thought I'd double-check.

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

@ChrisLMerrill I think your situation is a bit different. Also, I have MS Teams installed on my other PC and it works fine with LightBulb, so I don't think it's related to that.

You could however open device manager (Windows key + type "device manager" + press enter) and check what it says under "Display adapters".

@ChrisLMerrill
Copy link

Under display adapters, it lists AMD Radeon M370 and Intel HD Graphics 530, which is correct for my Dell E5570.

Under Monitors, it shows Dell U2410 (twice for my dual monitors) and Generic PnP Monitor, which I assume is my built-in display (inactive at the moment).

@Tyrrrz
Copy link
Owner

Tyrrrz commented Nov 14, 2019

@ChrisLMerrill let's continue discussion in #102, I left a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests