Should the parser tests be done separately as unit tests?

[Tyrrrz]

Currently integration tests are verifying both the parsing logic, as well as the integration with Youtube front-end itself.
Earlier I stood by this decision because with the rather few tests we had, it was a lot easier to test everything at once, instead of maintaining mock server responses.
Seeing how there are a lot more tests now, majority of which just verify the integration workflow in various scenarios (normal video, signed video, restricted video, normal playlist, long playlist, etc), it might be a good idea to move part of the assertions to unit tests. That way we can test the parsing logic once in unit tests, while integration tests will only assert conditions that are directly relevant to the scenario.

Pros:

• Reduce assertion clutter in integration tests
• Detect parsing issues more reliably with predictable assertions
• Able to test majority of YTE's logic offline

Cons:

• Have to maintain and update mock responses when Youtube changes something
• When something does change, it won't be as easy to detect it as it is now

Open discussion until 19th of April.

[Tyrrrz]

Fixed using a compromise in #19