-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handing for N-parameter in URLs #601
Conversation
Thanks! |
Your first link also mentions that this can be avoided altogether by masking requests as Android. Can we just do that? It seems like a way simpler solution.
|
Probably, slow bitrate problem will be solved with ANDROID client name but I chose definitive solution for WEB clients. |
Let's start with Android solution for now in a different PR and keep this one around for later, in case YouTube breaks that one too. Would you create a PR for that? |
I looked again and we cant this. Because |
@@ -13,6 +13,7 @@ | |||
<ItemGroup> | |||
<PackageReference Include="AngleSharp" Version="0.14.0" /> | |||
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="all" /> | |||
<PackageReference Include="NiL.JS" Version="2.5.1514" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this without interpreting JS somehow?
@omansak can you elaborate on why the Android approach can't be used in this library? |
"Probably, slow bitrate problem will be solved with ANDROID client name but I chose definitive solution for WEB clients." Which I find absurd because the first solution is more likely to cause issues than the second. The solution for android will always exist because how else will Youtube operate for non js platforms? |
For now went with the Android solution, let's see how long it lasts. All things considered, it's definitely simpler than the alternative. |
Going to close for now since we went with the Android solution. |
More info :
https://code.videolan.org/videolan/vlc/-/issues/26174#note_286445
ytdl-org/youtube-dl#29326