Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move field_set_op methods into a CFieldSet concept #79

Open
4 tasks
TzuChieh opened this issue Oct 1, 2023 · 0 comments
Open
4 tasks

Move field_set_op methods into a CFieldSet concept #79

TzuChieh opened this issue Oct 1, 2023 · 0 comments
Labels
Engine Core of the renderer. refactor

Comments

@TzuChieh
Copy link
Owner

TzuChieh commented Oct 1, 2023

field_set_op currently supports only TSdlOwnedField. However, the interface does not properly reflect that. We plan to perform the following refactors:

  • Abstract a set of fields using a CFieldSet concept (field set generally can be typed, as impl. types are all template based)
  • Make sure all operations used in field_set_op are present in concept CFieldSet
  • Replace all current impl. with the new concept and call methods from it directly
  • Remove field_set_op
@TzuChieh TzuChieh added Engine Core of the renderer. refactor labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engine Core of the renderer. refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TzuChieh