Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/87_grouper_refactor #117

Merged
merged 8 commits into from
Jan 22, 2021
Merged

feature/87_grouper_refactor #117

merged 8 commits into from
Jan 22, 2021

Conversation

astrochun
Copy link
Contributor

@astrochun astrochun commented Jan 13, 2021 •
edited
Loading

See #87

The following tests will need to occur manually to check that it is working with --sync:

  • script_run
    • test and test_reverse run
    • portal run
    • quota run
  • user_update
    • portal
    • quota
  • add_grouper_groups
    • main_themes
    • sub_portal
    • quota

@astrochun astrochun added this to the v0.16.0 milestone Jan 13, 2021
@astrochun astrochun added api Use of a third-party API enhancement New feature or request p2 Tier-2 issues that require addressing but not imminent labels Jan 13, 2021
@astrochun astrochun self-assigned this Jan 13, 2021
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Jan 13, 2021
@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Jan 13, 2021
@astrochun astrochun mentioned this pull request Jan 13, 2021
Closed
5 tasks
astrochun
astrochun commented Jan 20, 2021
View reviewed changes
Copy link
Contributor Author

@astrochun astrochun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look and --sync or --add testings was completed with scripts impacted by this refactor.

@astrochun astrochun changed the title feature/87_grouper_refactor [UNDER DEVELOPMENT - DO NOT MERGE] feature/87_grouper_refactor Jan 20, 2021
@astrochun astrochun moved this from In progress to Needs Review / Testing in ReDATA Patron Management Software Jan 20, 2021
This was referenced Jan 21, 2021
Closed
Closed
damian-romero
damian-romero approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@damian-romero damian-romero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment. I'll hold off on merging until you decide what to do.

requiam/commons.py Show resolved Hide resolved
@damian-romero damian-romero merged commit 1352fda into develop Jan 22, 2021
ReDATA Patron Management Software automation moved this from Needs Review / Testing to Done Jan 22, 2021
@zoidy zoidy deleted the feature/87_grouper_refactor branch June 29, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-romero damian-romero damian-romero approved these changes

Assignees

@astrochun astrochun

Labels
api Use of a third-party API enhancement New feature or request p2 Tier-2 issues that require addressing but not imminent
Projects
ReDATA Patron Management Software
  
Done
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astrochun @damian-romero