Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.1 #188

Merged
merged 3 commits into from
Jan 11, 2024
Merged

v1.1.1 #188

merged 3 commits into from
Jan 11, 2024

Conversation

yhan818
Copy link
Contributor

@yhan818 yhan818 commented Jan 6, 2024

Click the Preview tab and select a PR template:

@yhan818 yhan818 requested a review from zoidy January 6, 2024 05:50
Copy link
Collaborator

@zoidy zoidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changelog.md looks good
  • Need to bump the version number in the code
  • The v1.1.1 tag was created before this PR was merged. This triggered the GitHub action to generate a new release without the changes contained in this PR. Please delete that release and re-create it once this PR is merged

@yhan818 yhan818 requested a review from zoidy January 9, 2024 05:10
@yhan818
Copy link
Contributor Author

yhan818 commented Jan 9, 2024

removed the v1.1.1 tag and did a new pull request.

Copy link
Collaborator

@zoidy zoidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the tag. The version in the code still needs to be updated. Remember we have to update __init__.py. Refer to the release commit you did a while ago as an example

@yhan818 yhan818 requested a review from zoidy January 10, 2024 05:36
@yhan818 yhan818 merged commit e5fe1e7 into master Jan 11, 2024
7 checks passed
@yhan818 yhan818 deleted the version1.1.1 branch January 11, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants